[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to 'blockdev-add' |
|
Date: |
Tue, 15 Sep 2015 08:42:39 +0200 |
|
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng <address@hidden> wrote:
>> + backing = qdict_get_try_str(options, "backing");
>> + if (backing && *backing == '\0') {
>> + flags |= BDRV_O_NO_BACKING;
>> + }
>> + qdict_del(options, "backing");
>> +
> Specifying a non-empty "backing" will be a slient nop now, but it used
> to be an error before. Should we return an error?
Ah, yes, I think it should return an error. Thanks!
--- a/block.c
+++ b/block.c
@@ -1473,8 +1473,8 @@ static int bdrv_open_inherit(BlockDriverState
**pbs, const char *filename,
backing = qdict_get_try_str(options, "backing");
if (backing && *backing == '\0') {
flags |= BDRV_O_NO_BACKING;
+ qdict_del(options, "backing");
}
- qdict_del(options, "backing");
Berto