[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that ma
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that makes obvious sense |
|
Date: |
Mon, 14 Sep 2015 10:08:39 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/14/2015 09:51 AM, Eric Blake wrote:
> On 09/14/2015 05:53 AM, Markus Armbruster wrote:
>> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
>> for two reasons. One, it catches multiplication overflowing size_t.
>> Two, it returns T * rather than void *, which lets the compiler catch
>> more type errors.
>>
>> This commit only touches allocations with size arguments of the form
>> sizeof(T). Same Coccinelle semantic patchas in commit b45c03f.
s/patchas/patch as/
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> linux-user/elfload.c | 2 +-
>> linux-user/main.c | 2 +-
>> linux-user/syscall.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature