[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: Use g_new() & friends where that mak
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] migration: Use g_new() & friends where that makes obvious sense |
|
Date: |
Mon, 14 Sep 2015 09:51:34 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/14/2015 05:51 AM, Markus Armbruster wrote:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type errors.
>
> This commit only touches allocations with size arguments of the form
> sizeof(T). Same Coccinelle semantic patch as in commit b45c03f.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> migration/migration.c | 2 +-
> migration/qemu-file-buf.c | 2 +-
> migration/qemu-file-stdio.c | 4 ++--
> migration/qemu-file-unix.c | 4 ++--
> migration/qemu-file.c | 2 +-
> migration/rdma.c | 17 ++++++++---------
> migration/savevm.c | 12 ++++++------
> 7 files changed, 21 insertions(+), 22 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature