[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/34] linux-user: Support for restarting system
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH 33/34] linux-user: Support for restarting system calls for CRIS targets |
Date: |
Fri, 11 Sep 2015 16:26:10 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Sep 11, 2015 at 03:20:31PM +0100, Peter Maydell wrote:
> On 11 September 2015 at 15:18, Edgar E. Iglesias
> <address@hidden> wrote:
> > On Thu, Sep 10, 2015 at 08:12:21PM +0100, Peter Maydell wrote:
> >> On 6 September 2015 at 00:57, Timothy E Baldwin
> >> <address@hidden> wrote:
> >> > Signed-off-by: Timothy Edward Baldwin <address@hidden>
> >> > ---
> >> >
> >> > WARNING - NOT TESTED
> >> >
> >> > linux-user/cris/syscall.h | 2 ++
> >> > linux-user/main.c | 6 +++++-
> >> > linux-user/signal.c | 2 +-
> >> > 3 files changed, 8 insertions(+), 2 deletions(-)
>
>
> >> Looks OK, but this one I'm not sure enough about the CRIS instruction
> >> set and the surrounding code doesn't clarify. Edgar -- is the CRIS
> >> instruction for "take linux system call" always exactly 2 bytes long?
> >>
> >
> > Yes, those are always 2 bytes.
>
> Cool. In that case
> Reviewed-by: Peter Maydell <address@hidden>
>
Thanks, me too:
Reviewed-by: Edgar E. Iglesias <address@hidden>
- [Qemu-devel] [PATCH 28/34] linux-user: Restart sigaction() if signal pending, (continued)
- [Qemu-devel] [PATCH 28/34] linux-user: Restart sigaction() if signal pending, Timothy E Baldwin, 2015/09/05
- [Qemu-devel] [PATCH 23/34] linux-user: Queue synchronous signals separately, Timothy E Baldwin, 2015/09/05
- [Qemu-devel] [PATCH 32/34] linux-user: Support for restarting system calls for S390 targets, Timothy E Baldwin, 2015/09/05
- [Qemu-devel] [PATCH 22/34] linux-user: Remove real-time signal queuing, Timothy E Baldwin, 2015/09/05
- [Qemu-devel] [PATCH 33/34] linux-user: Support for restarting system calls for CRIS targets, Timothy E Baldwin, 2015/09/05
[Qemu-devel] [PATCH 18/34] linux-user: Fix race between multiple signals, Timothy E Baldwin, 2015/09/05
[Qemu-devel] [PATCH 24/34] linux-user: Restart execve() if signal pending, Timothy E Baldwin, 2015/09/05
[Qemu-devel] [PATCH 34/34] linux-user: Remove TARGET_USE_ERESTARTSYS, Timothy E Baldwin, 2015/09/05
[Qemu-devel] [PATCH 31/34] linux-user: Support for restarting system calls for M68K targets, Timothy E Baldwin, 2015/09/05
[Qemu-devel] [PATCH 02/34] linux-user: Reindent signal handling, Timothy E Baldwin, 2015/09/05
Re: [Qemu-devel] [PATCH 00/34] linux-user: Fix signal race conditions and SA_RESTART, Peter Maydell, 2015/09/10