[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 6/6] xen/pt: Use XEN_PT_LOG properly to guard aga
From: |
Konrad Rzeszutek Wilk |
Subject: |
[Qemu-devel] [PATCH v2 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings. |
Date: |
Tue, 8 Sep 2015 09:55:33 -0400 |
If XEN_PT_LOGGING_ENABLED is enabled the XEN_PT_LOG macros start
using the first argument. Which means if within the function there
is only one user of the argument ('d') and XEN_PT_LOGGING_ENABLED
is not set, we get compiler warnings. This is not the case now
but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config"
we will hit - so this sync up the function to the rest of them.
Reviewed-by: Stefano Stabellini <address@hidden>
Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
---
hw/xen/xen_pt_config_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 462e1b9..21d4938 100644
--- a/hw/xen/xen_pt_config_init.c
+++ b/hw/xen/xen_pt_config_init.c
@@ -1418,7 +1418,7 @@ static int
xen_pt_msixctrl_reg_init(XenPCIPassthroughState *s,
reg_field = pci_get_word(d->config + real_offset);
if (reg_field & PCI_MSIX_FLAGS_ENABLE) {
- XEN_PT_LOG(d, "MSIX already enabled, disabling it first\n");
+ XEN_PT_LOG(&s->dev, "MSIX already enabled, disabling it first\n");
xen_host_pci_set_word(&s->real_device, real_offset,
reg_field & ~PCI_MSIX_FLAGS_ENABLE);
}
--
2.1.0
- [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.,
Konrad Rzeszutek Wilk <=
- Re: [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors., Stefano Stabellini, 2015/09/08
- [Qemu-devel] [PATCH v2 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 1/6] xen/pt: Update comments with proper function name., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 5/6] xen/pt/msi: Add the register value when printing logging and error messages, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 2/6] xen/pt: Make xen_pt_msi_set_enable static, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap, Konrad Rzeszutek Wilk, 2015/09/08