Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

[Paolo Bonzini]

On 08/09/2015 09:09, Denis V. Lunev wrote:
>  qemu-monitor-info.texi           | 151 +++++++

This should be added in patch 4, not now.

> +const MonitorDef *target_monitor_defs(void) __attribute__((weak));
> +
> +const MonitorDef *target_monitor_defs(void)
> +{
> +    return NULL;
> +}

Weak symbols do not work on all platforms.  Luckily, making libqemustub
a static library gets exactly the same result without the need for weak
symbols: the definition from the QEMU object files will hide the stub.

You just need to remove __attribute__((weak)), and it should just work.

Otherwise, the patches look good to me.  Luiz, do you have time to post
a pull request for v4, or do you want to pass HMP maintainership as well
to someone else?

Paolo