[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: Add function pointers checks to memory_
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] memory: Add function pointers checks to memory_region_read/write() |
Date: |
Mon, 7 Sep 2015 12:27:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 03/09/2015 19:37, Salva Peiró wrote:
> The file memory.c directly calls the function pointers provided in
> the MemoryRegionOps to handle read and write operations for memory regions.
> The function pointers are called without checking if the function
> pointers are initialised, therefore, causing QEMU to SIGSEGV when
> accessing a memory address for which the operation is not defined (and not
> initialised)
>
> The patch adds explicit checks to function pointers before issuing the calls.
What device are you encountering this for? Perhaps this should be done
in memory_region_init_io instead, so that it is detected early.
Paolo