qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] configure: factor out adding disas configure


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] configure: factor out adding disas configure
Date: Mon, 7 Sep 2015 11:20:14 +0100

On 7 September 2015 at 11:02, Paolo Bonzini <address@hidden> wrote:
>
>
> On 29/08/2015 12:33, Peter Crosthwaite wrote:
>> Every arch adds its disas configury to both its own config as well
>> config_disas_all. Make a small function do to both at once.

>>  for i in $ARCH $TARGET_BASE_ARCH ; do
>>    case "$i" in
>>    alpha)
>> -    echo "CONFIG_ALPHA_DIS=y"  >> $config_target_mak
>> -    echo "CONFIG_ALPHA_DIS=y"  >> config-all-disas.mak
>> +    disas_config "ALPHA"
>>    ;;
>>    aarch64)
>>      if test -n "${cxx}"; then
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> $config_target_mak
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> config-all-disas.mak
>> +      disas_config "ARM_A64"
>>      fi
>>    ;;
>>    arm)
>> -    echo "CONFIG_ARM_DIS=y"  >> $config_target_mak
>> -    echo "CONFIG_ARM_DIS=y"  >> config-all-disas.mak
>> +    disas_config "ARM"
>>      if test -n "${cxx}"; then
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> $config_target_mak
>> -      echo "CONFIG_ARM_A64_DIS=y"  >> config-all-disas.mak
>> +      disas_config "ARM_A64"
>
> Why both?

Because this case is on $TARGET_BASE_ARCH, so if the
target is aarch64 we only see 'arm' here. (The
'aarch64' case is used for $ARCH, which is the
aarch64-host situation.)

>>  if test "$tcg_interpreter" = "yes" ; then
>> -  echo "CONFIG_TCI_DIS=y"  >> $config_target_mak
>> -  echo "CONFIG_TCI_DIS=y"  >> config-all-disas.mak
>> +  disas_config "TCI"
>>  fi
>
> Shouldn't TCI be a config_host property?

This is just the same way we say "host disassembler
is foo" for all hosts; TCI isn't any different here.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]