qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups


From: Markus Armbruster
Subject: [Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups
Date: Fri, 4 Sep 2015 16:21:07 +0200

The following changes since commit b041066421e8dcc7d080dfcfd83551c9c9f24ade:

  Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' 
into staging (2015-09-03 16:17:28 +0100)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-09-04

for you to fetch changes up to c4f498fe8532cdacc609262b104322911108df54:

  qapi: Generators crash when --output-dir isn't given, fix (2015-09-04 
15:47:16 +0200)

----------------------------------------------------------------
qapi: Another round of fixes and cleanups

----------------------------------------------------------------
Eric Blake (2):
      qapi: Document that input visitor semantics are prone to leaks
      qapi: Document shortcoming with union 'data' branch

Markus Armbruster (31):
      qapi: Clarify docs on including the same file multiple times
      qapi: Clean up cgen() and mcgen()
      qapi: Simplify guardname()
      qapi-event: Clean up how name of enum QAPIEvent is made
      qapi: Reject -p arguments that break qapi-event.py
      qapi: Drop unused and useless parameters and variables
      qapi: Fix generated code when flat union has member 'kind'
      qapi: Generate a nicer struct for flat unions
      qapi-visit: Fix generated code when schema has forward refs
      qapi-visit: Replace list implicit_structs by set
      qapi-visit: Fix two name arguments passed to visitors
      tests/qapi-schema: Document alternate's enum lacks visit function
      tests/qapi-schema: Document events with base don't work
      qapi: Document flaws in checking of names
      tests/qapi-schema: Restore test case for flat union base bug
      tests/qapi-schema: Rename tests from data- to args-
      qapi-tests: New tests for union, alternate command arguments
      qapi: Fix to reject union command and event arguments
      qapi: Command returning anonymous type doesn't work, outlaw
      qapi-commands: Fix gen_err_check(e) for e and e != 'local_err'
      qapi-commands: Inline gen_marshal_output_call()
      qapi-commands: Don't feed output of mcgen() to mcgen() again
      qapi-commands: Drop useless initialization
      qapi: Generated code cleanup
      qapi: Drop one of two "simple union must not have base" checks
      tests/qapi-schema: Cover two more syntax errors
      tests/qapi-schema: Cover non-string, non-dictionary members
      qapi: Fix errors for non-string, non-dictionary members
      qapi: Simplify error reporting for array types
      docs/qapi-code-gen.txt: Fix QAPI schema examples
      qapi: Generators crash when --output-dir isn't given, fix

 docs/qapi-code-gen.txt                             |  53 +++++-----
 scripts/qapi-commands.py                           | 109 +++++++++-----------
 scripts/qapi-event.py                              |   6 +-
 scripts/qapi-types.py                              | 110 +++++++++++----------
 scripts/qapi-visit.py                              |  93 ++++++++++-------
 scripts/qapi.py                                    |  81 +++++++--------
 tests/Makefile                                     |  12 ++-
 tests/qapi-schema/args-alternate.err               |   1 +
 ...ted-struct-returns.exit => args-alternate.exit} |   0
 tests/qapi-schema/args-alternate.json              |   3 +
 ...ested-struct-returns.out => args-alternate.out} |   0
 .../{data-array-empty.err => args-array-empty.err} |   2 +-
 .../{data-unknown.exit => args-array-empty.exit}   |   0
 ...data-array-empty.json => args-array-empty.json} |   0
 .../{data-unknown.out => args-array-empty.out}     |   0
 tests/qapi-schema/args-array-unknown.err           |   1 +
 ...member-unknown.exit => args-array-unknown.exit} |   0
 ...-array-unknown.json => args-array-unknown.json} |   0
 ...a-member-unknown.out => args-array-unknown.out} |   0
 tests/qapi-schema/args-int.err                     |   1 +
 .../{data-member-array-bad.exit => args-int.exit}  |   0
 tests/qapi-schema/{data-int.json => args-int.json} |   0
 .../{data-member-array.err => args-int.out}        |   0
 tests/qapi-schema/args-invalid.err                 |   1 +
 .../{data-int.exit => args-invalid.exit}           |   0
 tests/qapi-schema/args-invalid.json                |   2 +
 ...{data-member-array-bad.out => args-invalid.out} |   0
 ...ber-array-bad.err => args-member-array-bad.err} |   2 +-
 ...ray-unknown.exit => args-member-array-bad.exit} |   0
 ...r-array-bad.json => args-member-array-bad.json} |   0
 .../{data-int.out => args-member-array-bad.out}    |   0
 ...ata-array-unknown.out => args-member-array.err} |   0
 ...ta-member-array.exit => args-member-array.exit} |   0
 ...ta-member-array.json => args-member-array.json} |   0
 ...data-member-array.out => args-member-array.out} |   0
 tests/qapi-schema/args-member-unknown.err          |   1 +
 ...a-array-empty.exit => args-member-unknown.exit} |   0
 ...ember-unknown.json => args-member-unknown.json} |   0
 ...ata-array-empty.out => args-member-unknown.out} |   0
 tests/qapi-schema/args-union.err                   |   1 +
 tests/qapi-schema/args-union.exit                  |   1 +
 tests/qapi-schema/args-union.json                  |   4 +
 tests/qapi-schema/args-union.out                   |   0
 tests/qapi-schema/args-unknown.err                 |   1 +
 tests/qapi-schema/args-unknown.exit                |   1 +
 .../{data-unknown.json => args-unknown.json}       |   0
 tests/qapi-schema/args-unknown.out                 |   0
 tests/qapi-schema/command-int.json                 |   3 +-
 tests/qapi-schema/data-array-unknown.err           |   1 -
 tests/qapi-schema/data-int.err                     |   1 -
 tests/qapi-schema/data-member-unknown.err          |   1 -
 tests/qapi-schema/data-unknown.err                 |   1 -
 tests/qapi-schema/leading-comma-list.err           |   1 +
 tests/qapi-schema/leading-comma-list.exit          |   1 +
 tests/qapi-schema/leading-comma-list.json          |   2 +
 tests/qapi-schema/leading-comma-list.out           |   0
 tests/qapi-schema/leading-comma-object.err         |   1 +
 tests/qapi-schema/leading-comma-object.exit        |   1 +
 tests/qapi-schema/leading-comma-object.json        |   2 +
 tests/qapi-schema/leading-comma-object.out         |   0
 tests/qapi-schema/nested-struct-data.json          |   3 +-
 tests/qapi-schema/nested-struct-returns.err        |   1 -
 tests/qapi-schema/nested-struct-returns.json       |   3 -
 tests/qapi-schema/qapi-schema-test.json            |  39 +++++---
 tests/qapi-schema/qapi-schema-test.out             |  14 +--
 tests/qapi-schema/returns-dict.err                 |   1 +
 tests/qapi-schema/returns-dict.exit                |   1 +
 tests/qapi-schema/returns-dict.json                |   2 +
 tests/qapi-schema/returns-dict.out                 |   0
 tests/qapi-schema/returns-whitelist.err            |   2 +-
 tests/qapi-schema/struct-data-invalid.err          |   1 +
 tests/qapi-schema/struct-data-invalid.exit         |   1 +
 tests/qapi-schema/struct-data-invalid.json         |   2 +
 tests/qapi-schema/struct-data-invalid.out          |   0
 tests/qapi-schema/struct-member-invalid.err        |   1 +
 tests/qapi-schema/struct-member-invalid.exit       |   1 +
 tests/qapi-schema/struct-member-invalid.json       |   2 +
 tests/qapi-schema/struct-member-invalid.out        |   0
 tests/qapi-schema/union-base-no-discriminator.err  |   2 +-
 tests/test-qmp-event.c                             |   2 +-
 tests/test-qmp-input-visitor.c                     |   4 +-
 tests/test-qmp-output-visitor.c                    |   2 +-
 82 files changed, 317 insertions(+), 268 deletions(-)
 create mode 100644 tests/qapi-schema/args-alternate.err
 rename tests/qapi-schema/{nested-struct-returns.exit => args-alternate.exit} 
(100%)
 create mode 100644 tests/qapi-schema/args-alternate.json
 rename tests/qapi-schema/{nested-struct-returns.out => args-alternate.out} 
(100%)
 rename tests/qapi-schema/{data-array-empty.err => args-array-empty.err} (50%)
 rename tests/qapi-schema/{data-unknown.exit => args-array-empty.exit} (100%)
 rename tests/qapi-schema/{data-array-empty.json => args-array-empty.json} 
(100%)
 rename tests/qapi-schema/{data-unknown.out => args-array-empty.out} (100%)
 create mode 100644 tests/qapi-schema/args-array-unknown.err
 rename tests/qapi-schema/{data-member-unknown.exit => args-array-unknown.exit} 
(100%)
 rename tests/qapi-schema/{data-array-unknown.json => args-array-unknown.json} 
(100%)
 rename tests/qapi-schema/{data-member-unknown.out => args-array-unknown.out} 
(100%)
 create mode 100644 tests/qapi-schema/args-int.err
 rename tests/qapi-schema/{data-member-array-bad.exit => args-int.exit} (100%)
 rename tests/qapi-schema/{data-int.json => args-int.json} (100%)
 rename tests/qapi-schema/{data-member-array.err => args-int.out} (100%)
 create mode 100644 tests/qapi-schema/args-invalid.err
 rename tests/qapi-schema/{data-int.exit => args-invalid.exit} (100%)
 create mode 100644 tests/qapi-schema/args-invalid.json
 rename tests/qapi-schema/{data-member-array-bad.out => args-invalid.out} (100%)
 rename tests/qapi-schema/{data-member-array-bad.err => 
args-member-array-bad.err} (52%)
 rename tests/qapi-schema/{data-array-unknown.exit => 
args-member-array-bad.exit} (100%)
 rename tests/qapi-schema/{data-member-array-bad.json => 
args-member-array-bad.json} (100%)
 rename tests/qapi-schema/{data-int.out => args-member-array-bad.out} (100%)
 rename tests/qapi-schema/{data-array-unknown.out => args-member-array.err} 
(100%)
 rename tests/qapi-schema/{data-member-array.exit => args-member-array.exit} 
(100%)
 rename tests/qapi-schema/{data-member-array.json => args-member-array.json} 
(100%)
 rename tests/qapi-schema/{data-member-array.out => args-member-array.out} 
(100%)
 create mode 100644 tests/qapi-schema/args-member-unknown.err
 rename tests/qapi-schema/{data-array-empty.exit => args-member-unknown.exit} 
(100%)
 rename tests/qapi-schema/{data-member-unknown.json => 
args-member-unknown.json} (100%)
 rename tests/qapi-schema/{data-array-empty.out => args-member-unknown.out} 
(100%)
 create mode 100644 tests/qapi-schema/args-union.err
 create mode 100644 tests/qapi-schema/args-union.exit
 create mode 100644 tests/qapi-schema/args-union.json
 create mode 100644 tests/qapi-schema/args-union.out
 create mode 100644 tests/qapi-schema/args-unknown.err
 create mode 100644 tests/qapi-schema/args-unknown.exit
 rename tests/qapi-schema/{data-unknown.json => args-unknown.json} (100%)
 create mode 100644 tests/qapi-schema/args-unknown.out
 delete mode 100644 tests/qapi-schema/data-array-unknown.err
 delete mode 100644 tests/qapi-schema/data-int.err
 delete mode 100644 tests/qapi-schema/data-member-unknown.err
 delete mode 100644 tests/qapi-schema/data-unknown.err
 create mode 100644 tests/qapi-schema/leading-comma-list.err
 create mode 100644 tests/qapi-schema/leading-comma-list.exit
 create mode 100644 tests/qapi-schema/leading-comma-list.json
 create mode 100644 tests/qapi-schema/leading-comma-list.out
 create mode 100644 tests/qapi-schema/leading-comma-object.err
 create mode 100644 tests/qapi-schema/leading-comma-object.exit
 create mode 100644 tests/qapi-schema/leading-comma-object.json
 create mode 100644 tests/qapi-schema/leading-comma-object.out
 delete mode 100644 tests/qapi-schema/nested-struct-returns.err
 delete mode 100644 tests/qapi-schema/nested-struct-returns.json
 create mode 100644 tests/qapi-schema/returns-dict.err
 create mode 100644 tests/qapi-schema/returns-dict.exit
 create mode 100644 tests/qapi-schema/returns-dict.json
 create mode 100644 tests/qapi-schema/returns-dict.out
 create mode 100644 tests/qapi-schema/struct-data-invalid.err
 create mode 100644 tests/qapi-schema/struct-data-invalid.exit
 create mode 100644 tests/qapi-schema/struct-data-invalid.json
 create mode 100644 tests/qapi-schema/struct-data-invalid.out
 create mode 100644 tests/qapi-schema/struct-member-invalid.err
 create mode 100644 tests/qapi-schema/struct-member-invalid.exit
 create mode 100644 tests/qapi-schema/struct-member-invalid.json
 create mode 100644 tests/qapi-schema/struct-member-invalid.out

-- 
2.4.3




reply via email to

[Prev in Thread] Current Thread [Next in Thread]