Re: [Qemu-devel] [sheepdog] [PATCH 2/2] sheepdog: refine discard support

[Hitoshi Mitake]

On Wed, Sep 2, 2015 at 9:36 PM, Vasiliy Tolstov <address@hidden> wrote:
> 2015-09-01 6:03 GMT+03:00 Hitoshi Mitake <address@hidden>:
>> This patch refines discard support of the sheepdog driver. The
>> existing discard mechanism was implemented on SD_OP_DISCARD_OBJ, which
>> was introduced before fine grained reference counting on newer
>> sheepdog. It doesn't care about relations of snapshots and clones and
>> discards objects unconditionally.
>>
>> With this patch, the driver just updates an inode object for updating
>> reference. Removing the object is done in sheep process side.
>>
>> Cc: Teruaki Ishizaki <address@hidden>
>> Cc: Vasiliy Tolstov <address@hidden>
>> Cc: Jeff Cody <address@hidden>
>> Signed-off-by: Hitoshi Mitake <address@hidden>
>
>
> I'm test this patch and now discard working properly and no errors in
> sheepdog log file.
>
> Tested-by: Vasiliy Tolstov <address@hidden>

On the second thought, this patch has a problem of handling snapshot.
Please drop this one (1st patch is ok to apply).

I'll solve the problem in sheepdog side.

Thanks,
Hitoshi

>
> --
> Vasiliy Tolstov,
> e-mail: address@hidden
> --
> sheepdog mailing list
> address@hidden
> https://lists.wpkg.org/mailman/listinfo/sheepdog