Re: [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members

[Eric Blake]

On 08/31/2015 09:55 AM, Markus Armbruster wrote:
> We always report "should be a dictionary" then.  This is misleading:
> when allow_dict, it can be a dictionary or a type name string, else it
> can only be a type name.

This exposes the current (poor) conditions; then it will be obvious what
improvements a later patch to fix it actually has.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  tests/Makefile                               | 2 ++
>  tests/qapi-schema/args-invalid.err           | 1 +
>  tests/qapi-schema/args-invalid.exit          | 1 +
>  tests/qapi-schema/args-invalid.json          | 3 +++
>  tests/qapi-schema/args-invalid.out           | 0
>  tests/qapi-schema/struct-data-invalid.err    | 1 +
>  tests/qapi-schema/struct-data-invalid.exit   | 1 +
>  tests/qapi-schema/struct-data-invalid.json   | 3 +++
>  tests/qapi-schema/struct-data-invalid.out    | 0
>  tests/qapi-schema/struct-member-invalid.err  | 1 +
>  tests/qapi-schema/struct-member-invalid.exit | 1 +
>  tests/qapi-schema/struct-member-invalid.json | 3 +++
>  tests/qapi-schema/struct-member-invalid.out  | 0
>  13 files changed, 17 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature