Re: [Qemu-devel] [PATCH] hw/usb/bus.c: print device ID when 'info usb' used

[Daniel P. Berrange]

On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote:
> 
> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote:
> 
> > On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote:
> >> +            monitor_printf(mon, "  Device %d.%d, Port %s, Speed %s
> >> Mb/s,"
> >> +                                "Product %s, ID %s\n",
> >> +                           bus->busnr, dev->addr, port->path,
> >> +                           usb_speed(dev->speed),
> >> +                           dev->product_desc, dev->qdev.id);
> >> 
> > 
> > dev->qdev.id can be NULL.
> > 
> > cheers,
> >  Gerd
> 
> That isn't a problem. It will just say "null" when it is printed.
> No crash or garbage text.

Handling of '%s' with NULL is undefined by the standard. Linux
glibc prints the string "null", but other implementations can
crash.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|