[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed |
Date: |
Thu, 27 Aug 2015 08:42:02 -0500 |
User-agent: |
alot/0.3.6 |
Quoting Marc-André Lureau (2015-08-27 07:41:17)
> Hi
>
> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> <address@hidden> wrote:
> > This makes it easier to report on whether or not MSI support was
> > enabled via probe by looking at the ./configure summary.
>
> Sorry I don't get what that really changes. Otherwise the patch looks fine.
If we keep the $enabled != "no" logic all the way through, $enabled,
unless explicitly turned off or missing dependencies, will be
undefined when the configure options are summarized via:
configure: qemu-ga: report MSI install support in summary
requiring the user to infer whether we'll default to "yes" or "no".
The current logic in fact defaults to "yes" in function, so with this
patch we're simply setting that flag early on so we can report "yes"
rather than undefined.
>
>
> --
> Marc-André Lureau
>
[Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe, Michael Roth, 2015/08/26
[Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies, Michael Roth, 2015/08/26
[Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message, Michael Roth, 2015/08/26