Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

[Michael S. Tsirkin]

On Tue, Aug 25, 2015 at 12:16:04PM -0400, John Snow wrote:
> 
> 
> On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote:
> > On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote:
> >> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote:
> >>> * Eduardo Habkost (address@hidden) wrote:
> >>>> Migration with q35 was not possible before commit
> >>>> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally 
> >>>> creates
> >>>> an ich9-ahci device, that was marked as unmigratable. So all q35 machines
> >>>> before pc-q35-2.4 were unmigratable, and there's no point in keeping
> >>>> compatibility code for them.
> >>>>
> >>>> Remove all old pc-q35 machine classes and keep only pc-q35-2.4.
> >>>
> >>> But doesn't that mean that anyone who has a machine configured with one
> >>> of those machine types will suddenly find it wont start?
> >>
> >> Yes, and they will have to update their configuration to use pc-q35-2.4
> >> or newer.
> > 
> > That seems easily avoidable: just make pc-q35-X alias pc-q35-2.4 for X < 
> > 2.4.
> > 
> 
> Both Marcel and Markus would prefer it to fail outright instead of
> silently perform magic, in response to my suggesting the same thing.

I think it's result of a misunderstanding - let's discuss some more.

> >> -- 
> >> Eduardo