Re: [Qemu-devel] [PATCH 10/12] qga: add --dump-conf option

[Marc-André Lureau]

On Tue, Aug 25, 2015 at 7:11 PM, Michael Roth <address@hidden> wrote:
> I think we're missing fsfreeze_hook option here.
>

good catch

> To me it seems cleaner to actually create the GKeyFile from current
> options, then let GLib do all the work of generation a config file
> we can spit out (g_key_file_to_data() should do it i think).

I don't mind, why not.

> That, paired with the idea of having a GAConfig structure to
> encapulate all the config options, might warrant restructuring
> things a bit so that we have a
> gkeyfile_to_gaconfig()/gkeyfile_from_gaconfig() pair to use for
> reading/dumping configs while keeping all the options in an
> easily trackable place.




-- 
Marc-André Lureau