[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-mach
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix |
Date: |
Fri, 21 Aug 2015 08:44:24 -0700 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 21, 2015 at 12:23:01PM +0200, Cornelia Huck wrote:
> On Thu, 20 Aug 2015 14:54:26 -0700
> Eduardo Habkost <address@hidden> wrote:
>
> > The machine class names in QEMU are not consistent today. Some of them use
> > the
> > "-machine" suffix, but some use completely different naming conventions.
> > This
> > makes it difficult to implement machine class lookup without iterating
> > through
> > the whole list of machine classes.
> >
> > This series changes all machines to use "<machine name>-machine" as the
> > class
> > name, so we can simply use object_class_by_name() in the future to lookup
> > machine classes. (This was not done yet because it will also require some
> > changes in the way aliases are handled.)
>
> I've played around with the s390 machines a bit and it seems to do the
> right thing using the same commandlines as before.
>
> One question: info qom-tree shows the new machine class names - is
> there anybody (other than a human looking at it) making use of that
> information?
I don't believe anybody is using it. It would be possible to use the
class name for something useful if machines were user-creatable objects,
but they aren't.
--
Eduardo
- [Qemu-devel] [PATCH 01/10] machine: MACHINE_TYPE_NAME macro, (continued)
- [Qemu-devel] [PATCH 01/10] machine: MACHINE_TYPE_NAME macro, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 02/10] vexpress: Don't set name on abstract class, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 05/10] pseries: Rename machine class names to use MACHINE_TYPE_NAME, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 04/10] arm: Rename virt machine class to use MACHINE_TYPE_NAME, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 06/10] s390-virtio: Rename machine class name to use MACHINE_TYPE_NAME, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 09/10] machine: Ensure all TYPE_MACHINE subclasses have the right suffix, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 08/10] mac99: Use MACHINE_TYPE_NAME to encode class name, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 07/10] s390: Rename s390-ccw-virtio-2.4 class name to use MACHINE_TYPE_NAME, Eduardo Habkost, 2015/08/20
- [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically, Eduardo Habkost, 2015/08/20
- Re: [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix, Cornelia Huck, 2015/08/21
- Re: [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix,
Eduardo Habkost <=