[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwa
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] exec-all: Translate TCI return addresses backwards too |
Date: |
Tue, 18 Aug 2015 22:05:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
Am 18.08.2015 um 05:28 schrieb Peter Crosthwaite:
> This subtraction of return addresses applies directly to TCI as well as
> host-TCG. This fixes Linux boots for at least Microblaze, CRIS, ARM and
> SH4 when using TCI.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> Changed since v1:
> Wrote commit message.
> ---
> include/exec/exec-all.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
> index a6fce04..31c2405 100644
> --- a/include/exec/exec-all.h
> +++ b/include/exec/exec-all.h
> @@ -308,11 +308,7 @@ extern uintptr_t tci_tb_ptr;
> to indicate the compressed mode; subtracting two works around that. It
> is also the case that there are no host isas that contain a call insn
> smaller than 4 bytes, so we don't worry about special-casing this. */
> -#if defined(CONFIG_TCG_INTERPRETER)
> -# define GETPC_ADJ 0
> -#else
> # define GETPC_ADJ 2
> -#endif
>
> #define GETPC() (GETRA() - GETPC_ADJ)
Who should send the pull request? Me because it is TCI related?
I won't be able to send one before next week.
I also suggest to remove the indentation which is no longer
useful:
#define GETPC_ADJ 2
instead of
# define GETPC_ADJ 2
Maybe this can be done by the person who requests the pull.
Stefan