[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variabl
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 02/10] cpus: remove tcg_halt_cond global variable. |
Date: |
Thu, 13 Aug 2015 15:08:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 13/08/2015 15:05, Frederic Konrad wrote:
>>
>>
>> This removes tcg_halt_cond global variable.
>> We need one QemuCond per virtual cpu for multithread TCG.
>>
>> Signed-off-by: KONRAD Frederic <address@hidden>
>> Message-Id: <address@hidden>
>> [Keep tcg_halt_cond for bisectability, while making it static. - Paolo]
> How does that help bisectability?
With your patch (08/19), QEMU will only wait on first_cpu->halt_cond but
will call broadcast on cpu->halt_cond. Here I do the opposite: I wait
on cpu->halt_cond from some random CPU, but all of them point to the
same condvar tcg_halt_cond.
Paolo