[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction |
Date: |
Wed, 12 Aug 2015 10:14:18 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> + gen_logic_cc(s, res, opsize);
> +
> + l1 = gen_new_label();
> + l2 = gen_new_label();
> +
> + gen_jmpcc(s, 6 /* !Z */, l1);
> + gen_store(s, opsize, addr, update);
> + tcg_gen_br(l2);
> + gen_set_label(l1);
> + tcg_gen_mov_i32(cmp, dest);
> + gen_set_label(l2);
> + tcg_temp_free(dest);
> + tcg_temp_free(addr);
I would suggest writing this with movcond. It avoids the branch, which is
requiring the use of the local temps.
r~
- Re: [Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg, (continued)
- [Qemu-devel] [PATCH for-2.5 21/30] m68k: add bkpt, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 25/30] m68k: add abcd, sbcd, nbcd instructions, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 24/30] m68k: add DBcc and Scc (memory operand), Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction, Laurent Vivier, 2015/08/09
- Re: [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction,
Richard Henderson <=
- [Qemu-devel] [PATCH for-2.5 23/30] m68k: add linkl, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 28/30] m68k: shift/rotate bytes and words, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 26/30] m68k: add mull/divl, Laurent Vivier, 2015/08/09