|
From: | Frederic Konrad |
Subject: | Re: [Qemu-devel] [RFC PATCH V7 02/19] cpus: add tcg_exec_flag. |
Date: | Tue, 11 Aug 2015 13:11:57 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 11/08/2015 12:53, Paolo Bonzini wrote:
On 10/08/2015 17:27, address@hidden wrote:@@ -583,5 +587,6 @@ int cpu_exec(CPUState *cpu)/* fail safe : never use current_cpu outside cpu_exec() */current_cpu = NULL; + tcg_cpu_allow_execution(cpu);I don't think this is correct; safe_work_pending() is a much clearer test. I'll revert locally to the previous version to play more with the code. Paolo
Yes definitely but we might have a race if we just use safe_work_pending(). Fred
return ret; } diff --git a/include/qom/cpu.h b/include/qom/cpu.h
[Prev in Thread] | Current Thread | [Next in Thread] |