Re: [Qemu-devel] [PATCH v3 0/2] make: Cleanup and fix of loading of dependency info

[Michael S. Tsirkin]

On Sun, Aug 09, 2015 at 12:39:45PM +0300, Victor Kaplansky wrote:
> Changes from v2:
> 
>     Address comment by Paolo Bonzini:
>         - Store list of generated hex files in a variable and derive from it
>           list of dependences to be included.
> 
>     Address comment by Alex Bennee and Michael S. Tsirkin:
>         - Add a comment about difference between $(@D) and $(*D) in gnu make.
>         - Better explanation why touching of some *.dsl sources is necessary.
> 
> 
> make build can fail when one switches between commits without running
> "make clean".
> 
> This is caused by loading old *.d dependency info files and is harmful for
> autogenerated sources with their own includes.  This situation may
> significantly slow down the process of git bisect.
> 
> These two patches clean things up and fix the issue both for further versions,
> and between old and new commits.
> 
> This also replaces my previous patch "[PATCH] make: explicit dependencies for
> ACPI gen sources".
> 
> I've tested the fix by validating that lists included by previous "*.d"
> approach and new "patsubst" approach are identical.
> 

Looks good to me, though there's a minor coding style nit in patch 2/2.

Anyone has objections to merge this through my tree?

> 
> Victor Kaplansky (2):
>   make: fix where dependency *.d are stored.
>   make: load only required dependency files.
> 
>  hw/i386/Makefile.objs     | 8 +++++++-
>  hw/i386/acpi-dsdt.dsl     | 1 -
>  hw/i386/q35-acpi-dsdt.dsl | 1 +
>  rules.mak                 | 4 ++--
>  4 files changed, 10 insertions(+), 4 deletions(-)
> 
> -- 
> --Victor