qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v3 19/32] qapi: Clean up after recent conver


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH RFC v3 19/32] qapi: Clean up after recent conversions to QAPISchemaVisitor
Date: Wed, 5 Aug 2015 10:29:28 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 08/04/2015 09:58 AM, Markus Armbruster wrote:
> Generate just 'FOO' instead of 'struct FOO' when possible.
> 
> Drop helper functions that are now unused.
> 
> Make pylint reasonably happy.
> 
> Rename generate_FOO() functions to gen_FOO() for consistency.
> 
> Use more consistent and sensible variable names.
> 
> Consistently use c_ for mapping keys when their value is a C
> identifier or type.
> 
> Simplify gen_enum() and gen_visit_union()
> 
> Consistently use single quotes for C text string literals.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  docs/qapi-code-gen.txt   |   2 +-
>  scripts/qapi-commands.py | 129 +++++++++++++++++++++++-----------------------
>  scripts/qapi-event.py    | 121 ++++++++++++++++++++-----------------------
>  scripts/qapi-types.py    |  64 +++++++++++------------
>  scripts/qapi-visit.py    | 119 +++++++++++++++++++++---------------------
>  scripts/qapi.py          | 131 
> +++++++++--------------------------------------
>  6 files changed, 239 insertions(+), 327 deletions(-)
> 

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]