[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/g
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing |
Date: |
Wed, 5 Aug 2015 10:52:46 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jul 31, 2015 at 07:58:45PM +0200, Stefan Weil wrote:
> Am 31.07.2015 um 14:49 schrieb Paolo Bonzini:
> >On 31/07/2015 12:17, Daniel P. Berrange wrote:
> >> CC util/osdep.o
> >>In file included from include/qemu-common.h:48:0,
> >> from util/osdep.c:48:
> >>include/sysemu/os-win32.h:77:12: error: redundant redeclaration of
> >>'gmtime_r' [-Werror=redundant-decls]
> >> struct tm *gmtime_r(const time_t *timep, struct tm *result);
> >> ^
> >>In file included from include/qemu-common.h:35:0,
> >> from util/osdep.c:48:
> >>/usr/i686-w64-mingw32/sys-root/mingw/include/time.h:272:107: note: previous
> >>definition of 'gmtime_r' was here
> >>In file included from include/qemu-common.h:48:0,
> >> from util/osdep.c:48:
> >>include/sysemu/os-win32.h:79:12: error: redundant redeclaration of
> >>'localtime_r' [-Werror=redundant-decls]
> >> struct tm *localtime_r(const time_t *timep, struct tm *result);
> >> ^
> >>In file included from include/qemu-common.h:35:0,
> >> from util/osdep.c:48:
> >>/usr/i686-w64-mingw32/sys-root/mingw/include/time.h:269:107: note: previous
> >>definition of 'localtime_r' was here
> >>
> >>This change adds a configure test to see if localtime_r
> >>exits, and only enables the QEMU impl if missing. We also
> >>re-arrange qemu-common.h try attempt to guarantee that all
> >>source files get unistd.h before time.h and thus see the
> >>localtime_r/gmtime_r defs.
> >These are only with --enable-werror, right? The patch shouldn't be
> >necessary for 2.4.
> >
> >Paolo
>
> It isn't necessary for 2.4. There are more severe problems which also
> seem to be triggered by recent changes in the MinGW-w64 toolchain:
>
> 64 bit executables crash at longjmp from generated code,
> and networking fails because of asynchronous connect calls
> which were never implemented correctly in the slirp code.
> I'll try to summarize all that I know in a separate mail later.
>
> I only recently got reports about these problems and think
> that it is too late to fix them in 2.4.0.
Could you post the info about these problems, or point me to the bug
reports. I'm currently trying to get a patchset of mine working on
Win32 so need to understand what's broken with Mingw/Win32 currently.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH for-2.4] oslib-win32: only provide localtime_r/gmtime_r if missing,
Daniel P. Berrange <=
- [Qemu-devel] QEMU 2.4 for Windows - current status, Stefan Weil, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Paolo Bonzini, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Liviu Ionescu, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Paolo Bonzini, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Liviu Ionescu, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Stefan Weil, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Liviu Ionescu, 2015/08/05
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Kevin Wolf, 2015/08/06
- Re: [Qemu-devel] QEMU 2.4 for Windows - current status, Stefan Weil, 2015/08/06