[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v3 03/32] qapi: QAPISchema code generation h
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v3 03/32] qapi: QAPISchema code generation helper methods |
Date: |
Tue, 4 Aug 2015 16:18:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/04/2015 09:57 AM, Markus Armbruster wrote:
> New methods c_name(), c_type(), c_null(), json_type(),
> alternate_qtype().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi.py | 72
> +++++++++++++++++++++++++++++++++++++++++++++++++++------
> 1 file changed, 65 insertions(+), 7 deletions(-)
>
> def _def_predefineds(self):
> - for t in ['str', 'number', 'int', 'int8', 'int16', 'int32', 'int64',
> - 'uint8', 'uint16', 'uint32', 'uint64', 'size', 'bool',
> '**']:
> - self._def_builtin_type(t)
> + for t in [('str', 'string', 'char' + pointer_suffix, 'NULL'),
> + ('number', 'number', 'double', '0'),
So neither of us argued strongly enough for using '0.0' as the preferred
initializer for a double :)
The real fix compared to v2 was the handling of an empty enum, and that
looks correct.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH RFC v3 00/32] qapi: QMP introspection, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 09/32] Revert "qapi: Split up some typedefs to ease review", Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 01/32] qapi: Rename class QAPISchema to QAPISchemaParser, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 14/32] qapi-event: Eliminate global variable event_enum_value, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 04/32] qapi: New QAPISchemaVisitor, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 06/32] qapi: Split up some typedefs to ease review, Markus Armbruster, 2015/08/04
- [Qemu-devel] [PATCH RFC v3 03/32] qapi: QAPISchema code generation helper methods, Markus Armbruster, 2015/08/04
- Re: [Qemu-devel] [PATCH RFC v3 03/32] qapi: QAPISchema code generation helper methods,
Eric Blake <=
- [Qemu-devel] [PATCH RFC v3 02/32] qapi: New QAPISchema intermediate reperesentation, Markus Armbruster, 2015/08/04
[Qemu-devel] [PATCH RFC v3 08/32] Revert "qapi: Generate comments to simplify splitting for review", Markus Armbruster, 2015/08/04
[Qemu-devel] [PATCH RFC v3 12/32] qapi-commands: Convert to QAPISchemaVisitor, Markus Armbruster, 2015/08/04
[Qemu-devel] [PATCH RFC v3 18/32] qapi: Replace dirty is_c_ptr() by method c_null(), Markus Armbruster, 2015/08/04