[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu |
Date: |
Tue, 04 Aug 2015 16:11:40 +0100 |
Aurelien Jarno <address@hidden> writes:
> On 2015-08-03 10:14, Alex Bennée wrote:
>> This doesn't just dump CPU state on translation but on every block
>> entrance.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> ---
>> v4
>> - add r-b tag
>> ---
>> qemu-log.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qemu-log.c b/qemu-log.c
>> index 13f3813..be8405e 100644
>> --- a/qemu-log.c
>> +++ b/qemu-log.c
>> @@ -105,7 +105,7 @@ const QEMULogItem qemu_log_items[] = {
>> { CPU_LOG_EXEC, "exec",
>> "show trace before each executed TB (lots of logs)" },
>> { CPU_LOG_TB_CPU, "cpu",
>> - "show CPU state before block translation" },
>> + "show CPU registers before each executed TB (lots of logs)" },
>> { CPU_LOG_MMU, "mmu",
>> "log MMU-related activities" },
>> { CPU_LOG_PCALL, "pcall",
>
> In practice this is not true for linked TB. Should we also disable TB
> linking when this option is enabled?
Good question. I suspect yes because if you've gone to level of wanting
exec tracing you'll probably get confused by the chaining. Of course it
will run a lot slower then.
--
Alex Bennée
- [Qemu-devel] [PATCH v4 04/11] qemu-log: Avoid function call for disabled qemu_log_mask logging, (continued)
- [Qemu-devel] [PATCH v4 04/11] qemu-log: Avoid function call for disabled qemu_log_mask logging, Alex Bennée, 2015/08/03
- [Qemu-devel] [PATCH v4 02/11] tcg: light re-factor and pass down TranslationBlock, Alex Bennée, 2015/08/03
- [Qemu-devel] [PATCH v4 07/11] qemu-log: new option -dfilter to limit output, Alex Bennée, 2015/08/03
- [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Alex Bennée, 2015/08/03
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Aurelien Jarno, 2015/08/04
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu,
Alex Bennée <=
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Peter Maydell, 2015/08/04
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Richard Henderson, 2015/08/04
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Alex Bennée, 2015/08/04
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Richard Henderson, 2015/08/04
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Alex Bennée, 2015/08/04
- Re: [Qemu-devel] [PATCH v4 03/11] qemu-log: correct help text for -d cpu, Richard Henderson, 2015/08/04
[Qemu-devel] [PATCH v4 01/11] tcg: add ability to dump /tmp/perf-<pid>.map files, Alex Bennée, 2015/08/03