Re: [Qemu-devel] [PATCH v2] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on reinstall

[Marc-André Lureau]

Hi Leonid

On Mon, Aug 3, 2015 at 12:39 PM, Leonid Bloch <address@hidden> wrote:
> The property REINSTALLMODE had to be set to "amus", which contrary to the 
> default "omus" makes all the files to be reinstalled during upgrade, 
> regardless of their version. This is because the RemoveExistingProducts 
> element is now placed automatically, after InstallValidate, and thus can not 
> be placed in the very beginning of the installation sequence, as was the case 
> in the previous version of this patch.

Sorry I don't understand the REINSTALLMODE change. Could you clarify
what's the issue hit during install/update if you remove it?
Furthermore, that comment should be in the commit message, not in the
cover letter (a single patch can do without cover letter imho)

thanks


-- 
Marc-André Lureau