qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/12] net: add a new object netfilter


From: Yang Hongyang
Subject: Re: [Qemu-devel] [PATCH 01/12] net: add a new object netfilter
Date: Wed, 29 Jul 2015 22:32:08 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0



On 07/29/2015 10:20 PM, Thomas Huth wrote:
On Wednesday, July 29, 2015 4:05:38 PM,
"Yang Hongyang" <address@hidden> wrote:

On 07/29/2015 09:53 PM, Thomas Huth wrote:
On Wednesday, July 29, 2015 12:51:45 PM,
"Yang Hongyang" <address@hidden> wrote:

Signed-off-by: Yang Hongyang <address@hidden>

Maybe add at least a very short patch description? You're doing
a little bit more than just "add a new object netfilter" as
mentioned in the title...

How about:
Add a new object netfilter, used to capture packets send/receive
by network backend, init it after init net clients.

I rather thought about a short remark about the fact that this
patch also adds the "-netfilter" option. So maybe something
like this:

"Add the framework for a new netfilter object and a new
-netfilter CLI option as a basis for the following patches"

?

Seems better, thank you, will update!


  Thomas
.


--
Thanks,
Yang.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]