[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotp
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/2] vhost: check if vhost has capacity for hotplugged memory |
|
Date: |
Wed, 29 Jul 2015 10:33:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 28/07/2015 17:08, Igor Mammedov wrote:
>> > hw/mem/pc-dimm.c | 7 +++++++
>> > hw/virtio/vhost-backend.c | 23 ++++++++++++++++++++++-
>> > hw/virtio/vhost-user.c | 8 +++++++-
>> > hw/virtio/vhost.c | 21 +++++++++++++++++++++
>> > include/hw/virtio/vhost-backend.h | 2 ++
>> > include/hw/virtio/vhost.h | 1 +
>> > stubs/Makefile.objs | 1 +
>> > stubs/vhost.c | 6 ++++++
>> > 8 files changed, 67 insertions(+), 2 deletions(-)
>> > create mode 100644 stubs/vhost.c
>> >
> ping,
>
> patches are not invasive and fix QEMU crash during memory hotplug
> when running on kernels that have lower vhost memory slots limit.
> Pls consider applying them for 2.4.
I like the approach. For 2.5 we could consider using a
NotifierWithReturn: it can be easily extended to cover KVM as well and
removes the need for the stub.
Paolo