[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaV

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH RFC v2 26/47] qapi-types: Convert to QAPISchemaVisitor, fixing flat unions
Date: Tue, 28 Jul 2015 08:16:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 07/27/2015 10:09 AM, Markus Armbruster wrote:
>>> I'm sure there are further things that could be done, but at this point,
>>> I hope you get my picture, and I'll quit focusing on this particular patch.
>> We need to decide how much code churn to accept just for making the diff
>> of the generated code easier to review.
> At this point, I'd be happy with just adding a script or other
> high-level instructions in the commit message that says how to divide a
> generated file into pieces (pull out all *List types into one piece, all
> typedefs into another, etc) and which can be done both pre- and
> post-patch.  With pieces in hand, if you can easily compare that each
> pair is minimally different, then you have a nice reassurance that the
> difference in the overall file is due merely to differences in how the
> pieces are interleaved, and not to added or unintentionally dropped
> material.  As you pointed out, there comes a point of diminishing
> returns in trying to clean up code that will just be discarded.

I'll give it a try.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]