Re: [Qemu-devel] [PATCH 5/5] build-sys: generate QAPI doc based on json

[Eric Blake]

On 07/03/2015 03:51 AM, Marc-André Lureau wrote:
> Learn to generate info/html/pdf/man documentation for QEMU and agent QMP
> APIs.
> 
> This allows to provide missing agent documentation, and should help

s/allows to provide/provides/

> getting rid of the duplicate documentation in qmp-commands.hx.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  Makefile | 35 ++++++++++++++++++++++++++++++-----
>  1 file changed, 30 insertions(+), 5 deletions(-)
> 
> @@ -354,7 +356,7 @@ distclean: clean
>       rm -f qemu-doc.vr
>       rm -f config.log
>       rm -f linux-headers/asm
> -     rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi 
> qemu-tech.fn qemu-tech.info qemu-tech.ky qemu-tech.log qemu-tech.pdf 
> qemu-tech.pg qemu-tech.toc qemu-tech.tp qemu-tech.vr
> +     rm -f 
> qemu-{tech,qapi,ga-qapi}.{info,aux,cp,dvi,fn,info,.ky,log,pdf,pg,toc,tp,vr}

{} expansion is a bashism; it will probably fail to do what you meant on
systems where /bin/sh is dash.  But you could probably come up with
makefile $() functions to generate the same sort of compact
representation in the Makefile without relying on bashism. (Hmm, $(join)
isn't pairwise, and $(addprefix) only adds a single prefix; I'm not sure
offhand how to get all possible pairwise combinations of two lists...)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature