Re: [Qemu-devel] [PATCH v7 24/42] Add qemu_savevm_state_complete_postcopy

[Dr. David Alan Gilbert]

* Amit Shah (address@hidden) wrote:
> On (Tue) 16 Jun 2015 [11:26:37], Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> > 
> > Add qemu_savevm_state_complete_postcopy to complement
> > qemu_savevm_state_complete_precopy together with a new
> > save_live_complete_postcopy method on devices.
> > 
> > The save_live_complete_precopy method is called on
> > all devices during a precopy migration, and all non-postcopy
> > devices during a postcopy migration at the transition.
> > 
> > The save_live_complete_postcopy method is called at
> > the end of postcopy for all postcopiable devices.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> 
> Reviewed-by: Amit Shah <address@hidden>
> 
> But:
> 
> > --- a/migration/savevm.c
> > +++ b/migration/savevm.c
> > @@ -938,7 +938,47 @@ int qemu_savevm_state_iterate(QEMUFile *f)
> >  static bool should_send_vmdesc(void)
> >  {
> >      MachineState *machine = MACHINE(qdev_get_machine());
> > -    return !machine->suppress_vmdesc;
> > +    bool in_postcopy = migration_postcopy_phase(migrate_get_current());
> > +    return !machine->suppress_vmdesc && !in_postcopy;
> > +}
> 
> This should be split in its own patch.

Thanks, split.

Dave
> 
> 
>               Amit
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK