[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 4/6] Introduce irqchip type specification for

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v7 4/6] Introduce irqchip type specification for KVM
Date: Fri, 24 Jul 2015 17:42:06 +0100

On 24 July 2015 at 10:55, Pavel Fedin <address@hidden> wrote:
> This patch introduces kernel_irqchip_type member in Machine class, which
> is passed to kvm_arch_irqchip_create. Machine models which can use vGIC
> now use it in order to supply correct GIC type for KVM capability
> verification. The variable is defined as int in order to be
> architecture-agnostic for potential future uses by other architectures.

This doesn't look right. The board model should just create
the GIC device that it wants, and it should be the job of
the GIC device itself to coordinate with the kvm.c code
if it has to do so to pass the right kind of irqchip type.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]