Re: [Qemu-devel] [PATCH] tcg/aarch64: use 32-bit offset for 32-bit softmmu emulation

[Aurelien Jarno]

On 2015-07-23 15:14, Richard Henderson wrote:
> Similar to the same fix for user-mode, except this instance
> ocurrs on the softmmu path.  Again, the softmmu addend must
> be the base register, while the guest address is the index.
> 
> Cc: Claudio Fontana <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Aurelien Jarno <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> 
> While applying Paolo's fix for user-mode, I noticed this.
> I've never seen this fail, but obviously what we have is wrong.
> 
> This patch depends on Paolo's cleanup.
> 
> 
> r~
> ---
>  tcg/aarch64/tcg-target.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Good catch!

Reviewed-by: Aurelien Jarno <address@hidden>


-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
address@hidden                 http://www.aurel32.net