[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-i386/FPU: a misprint in helper_fistll_ST
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-i386/FPU: a misprint in helper_fistll_ST0 |
|
Date: |
Thu, 23 Jul 2015 23:59:48 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-07-08 12:48, Dmitry Poletaev wrote:
> There is a misprint in the patch
> https://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01657.html . It
> cause errors in guest work.
> Here is the bugfix.
>
> From: Dmitry Poletaev <address@hidden>
> Signed-off-by: Dmitry Poletaev <address@hidden>
> Reported-by: Kirill Batuzov <address@hidden>
>
> ---
> target-i386/fpu_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/fpu_helper.c b/target-i386/fpu_helper.c
> index fc25a03..fcf400d 100644
> --- a/target-i386/fpu_helper.c
> +++ b/target-i386/fpu_helper.c
> @@ -273,7 +273,7 @@ int64_t helper_fistll_ST0(CPUX86State *env)
> old_exp_flags = get_float_exception_flags(&env->fp_status);
> set_float_exception_flags(0, &env->fp_status);
>
> - val = floatx80_to_int32(ST0, &env->fp_status);
> + val = floatx80_to_int64(ST0, &env->fp_status);
> if (get_float_exception_flags(&env->fp_status) & float_flag_invalid) {
> val = 0x8000000000000000ULL;
> }
Reviewed-by: Aurelien Jarno <address@hidden>
Adding the maintainers of target-i386 in the loop so they might pick-up
the patch for 2.4.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net