[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floo

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor()
Date: Thu, 23 Jul 2015 21:10:30 +0100

On 23 July 2015 at 17:54, Paolo Bonzini <address@hidden> wrote:
> On 23/07/2015 13:08, Peter Maydell wrote:
>> We have a qemu_fls() function which is just a silly wrapper
>> around clz32() and which is used in only a handful of places
>> in the codebase. It turns out that all of those are really
>> trying to round up or down to a power of 2, which is something
>> we have utility functions for. This series replaces all
>> the qemu_fls() calls with pow2ceil() or pow2floor(), and then
>> removes the now-unused function.
> The series looks good, but I'd prefer (especially for patch 4 which is
> in a fast path) if pow2ceil and pow2floor were made inline.

Yeah, I was wondering if I was going to be asked to do that.
Note that qemu_fls() is/was *not* inline, though, so you're
taking an out-of-line function call on these code paths

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]