[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec: use macro for alignment
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] exec: use macro for alignment |
|
Date: |
Thu, 23 Jul 2015 12:43:25 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 23/07/2015 12:20, Chen Hanxiao wrote:
>
> +#define ALIGN(x, y) (((x)+(y)-1) & ~((y)-1))
> +
> static void *file_ram_alloc(RAMBlock *block,
> ram_addr_t memory,
> const char *path,
> @@ -1207,7 +1209,7 @@ static void *file_ram_alloc(RAMBlock *block,
> unlink(filename);
> g_free(filename);
>
> - memory = (memory+hpagesize-1) & ~(hpagesize-1);
> + memory = ALIGN(memory, hpagesize);
>
Hi,
the patch is a good idea, but please use ROUND_UP instead of defining
your own ALIGN macro.
Thanks!
Paolo