qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort
Date: Tue, 21 Jul 2015 17:18:50 +0100

On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí <address@hidden> wrote:
> From: Gerd Hoffmann <address@hidden>
>
> This is what it takes to have a sorted fw_cfg file directory.
> Entries are inserted at the correct place instead of being
> appended to the end in case sorting is enabled.
>
> Compatibility fluff (enable sorting for new machine types only)
> isn't there yet.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/nvram/fw_cfg.c | 30 ++++++++++++++++++++++++------
>  1 file changed, 24 insertions(+), 6 deletions(-)

Probably best to drop this patch from this series, unless it's needed.

I guess sorting files allows for binary search but it's unrelated to
DMA and needs to be accompanied with guest code (e.g. SeaBIOS) that
actually uses the feature.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]