[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 5/6] xen/pt/msi: Add the register value when
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages |
Date: |
Fri, 17 Jul 2015 16:26:07 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote:
> We would like to know what the MSI register value is to help
> in troubleshooting in the field. As such modify the logging
> logic to include such details in xen_pt_msgctrl_reg_write.
>
> Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
Reviewed-by: Stefano Stabellini <address@hidden>
> hw/xen/xen_pt_config_init.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
> index dd37be3..462e1b9 100644
> --- a/hw/xen/xen_pt_config_init.c
> +++ b/hw/xen/xen_pt_config_init.c
> @@ -1086,7 +1086,7 @@ static int
> xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
> /* setup MSI pirq for the first time */
> if (!msi->initialized) {
> /* Init physical one */
> - XEN_PT_LOG(&s->dev, "setup MSI\n");
> + XEN_PT_LOG(&s->dev, "setup MSI (register: %x).\n", *val);
> if (xen_pt_msi_setup(s)) {
> /* We do not broadcast the error to the framework code, so
> * that MSI errors are contained in MSI emulation code and
> @@ -1094,12 +1094,12 @@ static int
> xen_pt_msgctrl_reg_write(XenPCIPassthroughState *s,
> * Guest MSI would be actually not working.
> */
> *val &= ~PCI_MSI_FLAGS_ENABLE;
> - XEN_PT_WARN(&s->dev, "Can not map MSI.\n");
> + XEN_PT_WARN(&s->dev, "Can not map MSI (register: %x)!\n",
> *val);
> return 0;
> }
> if (xen_pt_msi_update(s)) {
> *val &= ~PCI_MSI_FLAGS_ENABLE;
> - XEN_PT_WARN(&s->dev, "Can not bind MSI\n");
> + XEN_PT_WARN(&s->dev, "Can not bind MSI (register: %x)!\n",
> *val);
> return 0;
> }
> msi->initialized = true;
> --
> 2.1.0
>
- [Qemu-devel] [PATCH v1] Cleanups + various fixes due to libxl ABI + more logging on errors., Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 1/6] xen/pt: Update comments with proper function name., Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages, Konrad Rzeszutek Wilk, 2015/07/02
- Re: [Qemu-devel] [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages,
Stefano Stabellini <=
- [Qemu-devel] [PATCH v1 2/6] xen/pt: Make xen_pt_msi_set_enable static, Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap, Konrad Rzeszutek Wilk, 2015/07/02
- [Qemu-devel] [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings., Konrad Rzeszutek Wilk, 2015/07/02