[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code int
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder |
Date: |
Wed, 15 Jul 2015 14:08:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 07/14/15 22:23, Wei Huang wrote:
> To share smbios among different architectures, this patch moves SMBIOS
> code (smbios.c and smbios.h) from x86 specific folders into new
> hw/smbios directories. As a result, CONFIG_SMBIOS=y is defined in
> x86 default config files.
>
> Signed-off-by: Wei Huang <address@hidden>
> ---
> arch_init.c | 2 +-
> default-configs/i386-softmmu.mak | 1 +
> default-configs/x86_64-softmmu.mak | 1 +
> hw/Makefile.objs | 1 +
> hw/i386/Makefile.objs | 2 +-
> hw/i386/pc.c | 2 +-
> hw/i386/pc_piix.c | 2 +-
> hw/i386/pc_q35.c | 2 +-
> hw/i386/smbios.c | 1102
> ------------------------------------
> hw/smbios/Makefile.objs | 1 +
> hw/smbios/smbios.c | 1102
> ++++++++++++++++++++++++++++++++++++
> include/hw/i386/smbios.h | 237 --------
> include/hw/smbios/smbios.h | 237 ++++++++
> tests/bios-tables-test.c | 2 +-
> vl.c | 2 +-
> 15 files changed, 1350 insertions(+), 1346 deletions(-)
> delete mode 100644 hw/i386/smbios.c
> create mode 100644 hw/smbios/Makefile.objs
> create mode 100644 hw/smbios/smbios.c
> delete mode 100644 include/hw/i386/smbios.h
> create mode 100644 include/hw/smbios/smbios.h
Can you please send the next version of this series (I assume there's
going to be one) with rename detection enabled? At least
"hw/i386/smbios.c" --> "hw/smbios/smbios.c" appears a rename. A few
lines may have changed, but without enabling rename detection, it's
really hard to tell.
Thanks
Laszlo
- [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM, Wei Huang, 2015/07/14
- [Qemu-devel] [ARM SMBIOS RFC PATCH 3/5] smbios: pass ram size as a parameter to build smbios tables, Wei Huang, 2015/07/14
- [Qemu-devel] [ARM SMBIOS RFC PATCH 2/5] smbios: remove dependency on x86 e820 tables, Wei Huang, 2015/07/14
- [Qemu-devel] [ARM SMBIOS RFC PATCH 1/5] smbios: extract x86 smbios building code into a function, Wei Huang, 2015/07/14
- [Qemu-devel] [ARM SMBIOS RFC PATCH 5/5] smbios: implement smbios support for mach-virt, Wei Huang, 2015/07/14
- [Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder, Wei Huang, 2015/07/14
- Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder,
Laszlo Ersek <=
- Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM, Laszlo Ersek, 2015/07/14
- Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM, Laszlo Ersek, 2015/07/15
- Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 0/5] SMBIOS Support for ARM, Gabriel L. Somlo, 2015/07/16