[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [RFC PATCH v0] spapr: Abort when hash table size requiremen

From: Bharata B Rao
Subject: [Qemu-devel] [RFC PATCH v0] spapr: Abort when hash table size requirement isn't met
Date: Wed, 15 Jul 2015 15:27:13 +0530

[This patch addresses an issue which is not prominently seen in mainline,
but seen frequently only in David's spapr-next branch. Though it is possible
to see this issue with mainline too, the current version of the patch
is intended for David's tree.]

QEMU requests for hash table allocation through KVM_PPC_ALLOCATE_HTAB ioctl
by providing the size hint via htab_shift value. Sometimes the hinted
size requirement can't be met by the host and it returns with a lower
value for htab_shift.

This was fine until recently where the hash table size was dependent
on guest RAM size. With the intention of supporting memory hotplug, hash
table size was changed to depend on maxram size recently. Since it is
typical to have maxram size to be much higher than RAM size, the possibility
of host not being able to meet the size requirement has increased. This
causes two problems:

- When memory hotplug is supported, we will not be able to grow till
  maxram if the host wasn't able to satisfy the hash table size for the
  the full maxram range.
- During migration, we can end up having different htab_shift values (and
  hence different hash table sizes) at the source and target due to
  which the migration fails.

Prevent the above conditions by refusing to start the guest if the
QEMU-requested hash table size requiement isn't met by the host.

Signed-off-by: Bharata B Rao <address@hidden>
 hw/ppc/spapr.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 4a648af..6ffe198 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1003,6 +1003,20 @@ static void spapr_reset_htab(sPAPRMachineState *spapr)
     if (shift > 0) {
         /* Kernel handles htab, we don't need to allocate one */
+        if (spapr->htab_shift != shift) {
+            /*
+             * Host couldn't allocate the hash table with the requested
+             * size. This can lead to two problems later:
+             * - Failure to grow till maxram_size via hotplug.
+             * - Failure to migrate if the host at the target ends up
+             *   allocating a different sized hash table.
+             *
+             * Prevent such conditions by aborting now.
+             */
+            error_setg(&error_abort, "Unable to allocate hash table, try "
+                                     "with smaller maxmem value");
+        }
         spapr->htab_shift = shift;
         kvmppc_kern_htab = true;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]