[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used
|
From: |
Meador Inge |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used |
|
Date: |
Mon, 13 Jul 2015 13:08:02 -0700 |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote:
> Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h
On second thought, I was following an existing pattern in 'main.c'. Really
fixing this would require changing around 30 other locations too. I think
if we are going to switch to the EXIT_* macros, then the whole file should
be changed in one patch and making that fix shouldn't hold this patch up.
-- Meador
- [Qemu-devel] [PATCH 0/4] linux-user: CLI cleanup, meadori, 2015/07/06
- [Qemu-devel] [PATCH 3/4] linux-user: Add proper error messages for bad options, meadori, 2015/07/06
- [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used, meadori, 2015/07/06
- [Qemu-devel] [PATCH 2/4] linux-user: Add -help, meadori, 2015/07/06
- [Qemu-devel] [PATCH 4/4] linux-user: Treat --foo options the same as -foo, meadori, 2015/07/06
- Re: [Qemu-devel] [PATCH 0/4] linux-user: CLI cleanup, Laurent Vivier, 2015/07/06