[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 04/16] ich9: add TCO interface emulation
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PULL v2 04/16] ich9: add TCO interface emulation |
Date: |
Mon, 13 Jul 2015 15:19:51 +0530 |
On (Wed) 08 Jul 2015 [12:41:35], Michael S. Tsirkin wrote:
> From: Paulo Alcantara <address@hidden>
>
> This interface provides some registers within a 32-byte range and can be
> acessed through PCI-to-LPC bridge interface (PMBASE + 0x60).
>
> It's commonly used as a watchdog timer to detect system lockups through
> SMIs that are generated -- if TCO_EN bit is set -- on every timeout. If
> NO_REBOOT bit is not set in GCS (General Control and Status register),
> the system will be resetted upon second timeout if TCO_RLD register
> wasn't previously written to prevent timeout.
>
> This patch adds support to TCO watchdog logic and few other features
> like mapping NMIs to SMIs (NMI2SMI_EN bit), system intruder detection,
> etc. are not implemented yet.
>
> Signed-off-by: Paulo Alcantara <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index f4dc7a8..5fb7a87 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> const VMStateDescription vmstate_ich9_pm = {
> .name = "ich9_pm",
> .version_id = 1,
> @@ -179,6 +207,10 @@ const VMStateDescription vmstate_ich9_pm = {
> .subsections = (const VMStateDescription*[]) {
> &vmstate_memhp_state,
> NULL
> + },
> + .subsections = (const VMStateDescription*[]) {
> + &vmstate_tco_io_state,
> + NULL
> }
> };
This isn't the right way to add subsections - vmstate_tco_io_state
should go inside the existing .subsections array. The effect this
commit has is that vmstate_memhp_state is not registered as a
subsection anymore.
Please fix.
Spotted by the static checker.
Amit
- [Qemu-devel] [PULL v2 00/16] pc,virtio,pci: fixes and updates, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 01/16] dataplane: fix cross-endian issues, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 03/16] acpi: split out ICH ACPI support, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 02/16] Revert "dataplane: allow virtio-1 devices", Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 04/16] ich9: add TCO interface emulation, Michael S. Tsirkin, 2015/07/08
- Re: [Qemu-devel] [PULL v2 04/16] ich9: add TCO interface emulation,
Amit Shah <=
- [Qemu-devel] [PULL v2 06/16] ich9: implement strap SPKR pin logic, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 05/16] tests: add testcase for TCO watchdog emulation, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 07/16] hw/i386/pc: factor out pc_cmos_init_floppy(), Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 08/16] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 09/16] hw/i386/pc: don't carry FDC from pc_basic_device_init() to pc_cmos_init(), Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 10/16] virtio_net: reuse constants from linux, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 12/16] pcie: Set the "link active" in the link status register, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 13/16] virtio: define virtio_pci_cfg_cap in header., Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 15/16] virtio fix cfg endian-ness for BE targets, Michael S. Tsirkin, 2015/07/08
- [Qemu-devel] [PULL v2 14/16] virtio-pci: implement cfg capability, Michael S. Tsirkin, 2015/07/08