Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

[Peter Crosthwaite]

On Wed, Jun 24, 2015 at 2:50 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 24/06/2015 06:22, Peter Crosthwaite wrote:
>> For a summary here is the review state of the multi-arch patch queue.
>> I have too many reviewed-but-unapplied patches I have stopped working
>> on the feature until I get some of this already-reviewed work off my
>> hands (read bottom up):
>
> git log --reverse FTW. :)
>

Added that to my script :) Much more readable.

> For now I have queued these:
>
> d7daf77764   cpu-defs: Move out TB_JMP defines
> 527c8d113c   include/exec: Move tb hash functions out
> dfe5fb5153   include/exec: Move standard exceptions to cpu-all.h
> edff94d9b5   cpu-defs: Move CPU_TEMP_BUF_NLONGS to tcg
> d8faad7ed2   memory_mapping: Rework cpu related includes
>
> Now on to the others.  Some are blocked by Bharata's work, and no one
> knows what tree will shepherd them?!?
>
> Then: these will probably be queued by Andreas?
>

Yes between you, Andreas and Alex, everything merge-intended (+more -
thanks for the cherry picks from the RFC) is in on the hard-freeze
merges.

>> ea291ffcde     microblaze: boot: Use cpu_set_pc()                          
>> R:af
>> 11d804948d     arm: boot: Use cpu_set_pc()
>>     R:pmm R:af
>> 13dd9e90b1     gdbstub: Use cpu_set_pc() helper
>> 07ca0ce6b4     cpu: Add wrapper to the set-pc() hook
>> 4d46aa8725     disas: cris: QOMify target specific disas setup
>>     R:edgar_x
>> 22bbba694f     disas: cris: Fix 0 buffer length case
>>     R:edgar_x
>> 8b16aff59c     disas: microblaze: QOMify target specific disas setup
>>     R:edgar_x
>> 8c08b3d14a     disas: arm: QOMify target specific disas setup              
>> R:pmm
>> 7ca536d824     disas: arm-a64: Make printfer and stream variable
>>     R:claudio T:claudio R:rth
>> b316905406     disas: QOMify target specific setup                         
>> R:rth
>> d10c5b0fc8     disas: Add print_insn to disassemble info                   
>> R:rth
>
> For this one I hadn't answered you, and I have looked into it further
> today.  However, I'm leaning towards omitting it for 2.4:
>
>> fa2e6624f9   cpu-common: Define tb_page_addr_t for everyone
>
> This one fails compilation for me when extracted from the series:
>

Yes, I am now working through fully-configured build testing on the
next RFC. My strategy is to send the big RFCs which are
semi-functional to gives reviewers full context on what I am trying to
do and sometimes things aren't merge ready. At the same time I am
extracting components as shorter series or singles as non-RFCs (which
AFAIK are problem free) so they can be taken into a number of
different queues independently.

With the hard freeze merges 23 down, 37 to go :). RFCv3 coming
shortly. Hoping to collect RBs during the freeze then target 2.5
first-flushes.

Regards,
Peter


>> 9d708b430b   include/exec: Move cputlb exec.c defs out
>
> This one, I cannot find on the list:
>
>> 5d2163a21b     cpu_defs: Simply CPUTLB padding logic
>
> The first below need an ack from Alex Williamson, but these can also go
> in 2.4:
>
>> 3a9e19c7f7     vfio: cpu: Use "real" page size API
>>     T:alexey
>> edbb1333e9     cpu-all: complete "real" host page size API
>>     T:alexey
>
> Paolo
>