[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less de
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices |
Date: |
Thu, 09 Jul 2015 18:59:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Am 09.07.2015 um 18:51 schrieb Cornelia Huck:
> Devices that don't live on a bus aren't caught by the normal device
> reset logic. Let's register a reset handler for those devices during
> device realization that calls the reset handler for the associated
> device class.
>
> Suggested-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> hw/core/qdev.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
Looks acceptable as solution for 2.4... However, I would like to
understand why the parent device cannot reset it? Someone created that
device in the first place. I would prefer you call device_reset() from
there without this generic patch.
A similar discussion took place for the x86 APIC.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
- [Qemu-devel] [PATCH for-2.4 0/2] reset for bus-less devices, Cornelia Huck, 2015/07/09
- [Qemu-devel] [PATCH for-2.4 2/2] watchdog/diag288: handle subsystem resets correctly, Cornelia Huck, 2015/07/09
- [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Cornelia Huck, 2015/07/09
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices,
Andreas Färber <=
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Christian Borntraeger, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Cornelia Huck, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Andreas Färber, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Christian Borntraeger, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Andreas Färber, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Cornelia Huck, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Andreas Färber, 2015/07/13
- Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices, Peter Maydell, 2015/07/13