[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in nod
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info |
Date: |
Thu, 9 Jul 2015 17:18:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 09/07/2015 17:10, Bharata B Rao wrote:
> On Thu, Jul 09, 2015 at 04:12:09PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 03/07/2015 22:50, Eduardo Habkost wrote:
>>> From: Bharata B Rao <address@hidden>
>>>
>>> Store memory address range information of boot memory in address
>>> range list of numa_info.
>>>
>>> This helps to have a common NUMA node lookup by address function that
>>> works for both boot-time memory and hotplugged memory.
>>>
>>> Signed-off-by: Bharata B Rao <address@hidden>
>>> Reviewed-by: David Gibson <address@hidden>
>>> Tested-by: Igor Mammedov <address@hidden>
>>> Signed-off-by: Eduardo Habkost <address@hidden>
>>> ---
>>> numa.c | 27 +++++++++++++++++++++++++++
>>> 1 file changed, 27 insertions(+)
>>>
>>> diff --git a/numa.c b/numa.c
>>> index 116d1fb..a73f648 100644
>>> --- a/numa.c
>>> +++ b/numa.c
>>> @@ -56,6 +56,14 @@ void numa_set_mem_node_id(ram_addr_t addr, uint64_t
>>> size, uint32_t node)
>>> {
>>> struct numa_addr_range *range = g_malloc0(sizeof(*range));
>>>
>>> + /*
>>> + * Memory-less nodes can come here with 0 size in which case,
>>> + * there is nothing to do.
>>> + */
>>> + if (!size) {
>>> + return;
>>
>> This leaks "range".
>
> Should I post this fix as an independent thread ?
Yes, please.
Paolo
>
> numa: Fix memory leak in numa_set_mem_node_id()
>
> From: Bharata B Rao <address@hidden>
>
> Fix a memory leak in numa_set_mem_node_id().
>
> Signed-off-by: Bharata B Rao <address@hidden>
> ---
> numa.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/numa.c b/numa.c
> index 3c80059..402804b 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -54,7 +54,7 @@ NodeInfo numa_info[MAX_NODES];
>
> void numa_set_mem_node_id(ram_addr_t addr, uint64_t size, uint32_t node)
> {
> - struct numa_addr_range *range = g_malloc0(sizeof(*range));
> + struct numa_addr_range *range;
>
> /*
> * Memory-less nodes can come here with 0 size in which case,
> @@ -64,6 +64,7 @@ void numa_set_mem_node_id(ram_addr_t addr, uint64_t size,
> uint32_t node)
> return;
> }
>
> + range = g_malloc0(sizeof(*range));
> range->mem_start = addr;
> range->mem_end = addr + size - 1;
> QLIST_INSERT_HEAD(&numa_info[node].addr, range, entry);
>
- [Qemu-devel] [PULL 0/6] NUMA queue, 2015-07-03, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 1/6] pc, pc-dimm: Extract hotplug related fields in PCMachineState to a structure, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 2/6] pc, pc-dimm: Factor out reusable parts in pc_dimm_plug to a separate routine, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 3/6] pc: Abort if HotplugHandlerClass::plug() fails, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 4/6] numa, pc-dimm: Store pc-dimm memory information in numa_info, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 6/6] numa: API to lookup NUMA node by address, Eduardo Habkost, 2015/07/03
- [Qemu-devel] [PULL 5/6] numa: Store boot memory address range in node_info, Eduardo Habkost, 2015/07/03
- Re: [Qemu-devel] [PULL 0/6] NUMA queue, 2015-07-03, Peter Maydell, 2015/07/05