[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PULL 27/28] migration: protect migration_bitmap
Date: Thu, 9 Jul 2015 09:59:33 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1

On 09/07/2015 03:19, Wen Congyang wrote:
> Yes, why migration doesn't trigger this problem? We will fix it soon.

This should be the fix if someone wants to test it and/or post it:

diff --git a/migration/ram.c b/migration/ram.c
index 57368e1..8d5a73a 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1227,9 +1227,9 @@ static int ram_save_complete(QEMUFile *f, void

     ram_control_after_iterate(f, RAM_CONTROL_FINISH);
-    migration_end();
+    migration_end();
     qemu_put_be64(f, RAM_SAVE_FLAG_EOS);

     return 0;

You don't see it with migration because the migration thread (and for
that matter, _no_ thread except the I/O thread!) is not registered with
the RCU subsystem.  I'm working on it, but I plan to only fix it in
later release candidates.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]