[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/4] target-s390x: fix CONVERT TO BINARY (CVD, CVDY)
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PULL 3/4] target-s390x: fix CONVERT TO BINARY (CVD, CVDY) |
Date: |
Tue, 7 Jul 2015 17:52:40 +0200 |
From: Aurelien Jarno <address@hidden>
current_number being shift left by more than 32 bits, we can't use a
simple int. Similarly use an int64_t type for the input binary value,
to not get the -2^31 case wrong. Finally don't initialize shift to 4,
it's already done in the for loop.
Signed-off-by: Aurelien Jarno <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
---
target-s390x/int_helper.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/target-s390x/int_helper.c b/target-s390x/int_helper.c
index 2c2b3f6..a46c736 100644
--- a/target-s390x/int_helper.c
+++ b/target-s390x/int_helper.c
@@ -121,11 +121,12 @@ uint64_t HELPER(clz)(uint64_t v)
return clz64(v);
}
-uint64_t HELPER(cvd)(int32_t bin)
+uint64_t HELPER(cvd)(int32_t reg)
{
/* positive 0 */
uint64_t dec = 0x0c;
- int shift = 4;
+ int64_t bin = reg;
+ int shift;
if (bin < 0) {
bin = -bin;
@@ -133,9 +134,7 @@ uint64_t HELPER(cvd)(int32_t bin)
}
for (shift = 4; (shift < 64) && bin; shift += 4) {
- int current_number = bin % 10;
-
- dec |= (current_number) << shift;
+ dec |= (bin % 10) << shift;
bin /= 10;
}
--
1.7.12.4
- [Qemu-devel] [PULL 0/4] s390 patch queue 2015-07-07, Alexander Graf, 2015/07/07
- [Qemu-devel] [PULL 1/4] target-s390x: fix MOVE LONG instruction, Alexander Graf, 2015/07/07
- [Qemu-devel] [PULL 2/4] target-s390x: fix EXECUTE instruction executing TRT, Alexander Graf, 2015/07/07
- [Qemu-devel] [PULL 3/4] target-s390x: fix CONVERT TO BINARY (CVD, CVDY),
Alexander Graf <=
- [Qemu-devel] [PULL 4/4] tcg/s390: fix branch target change during code retranslation, Alexander Graf, 2015/07/07
- Re: [Qemu-devel] [PULL 0/4] s390 patch queue 2015-07-07, Peter Maydell, 2015/07/08