[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 12/12] i386/kvm: Hyper-v crash msrs set/get'ers

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 12/12] i386/kvm: Hyper-v crash msrs set/get'ers and migration
Date: Tue, 7 Jul 2015 12:21:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1

On 03/07/2015 14:01, Denis V. Lunev wrote:
> @@ -904,6 +905,7 @@ typedef struct CPUX86State {
>      uint64_t msr_hv_guest_os_id;
>      uint64_t msr_hv_vapic;
>      uint64_t msr_hv_tsc;
> +    uint64_t msr_hv_crash_prm[HV_X64_MSR_CRASH_PARAMS];

Do not abbreviate variable names!  The enum even says PARAMS, so use
params in the array name as well.

I've done the change locally in all files.


>      /* exception/interrupt handling */
>      int error_code;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]