[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: update bdrv_drain_all()/bdrv_drain() com
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] block: update bdrv_drain_all()/bdrv_drain() comments |
Date: |
Tue, 7 Jul 2015 10:32:41 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Jul 02, 2015 at 05:24:41PM +0100, Stefan Hajnoczi wrote:
> The doc comments for bdrv_drain_all() and bdrv_drain() are outdated:
>
> * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock()
> which Fam Zheng is currently developing. Unfortunately this warning
> was never really enough because devices keep submitting I/O and op
> blockers don't prevent that.
>
> * The bdrv_drain_all() comment is still partially correct but reflects
> the nature of the implementation rather than API documentation.
>
> Do make it clear that bdrv_drain() is only appropriate within an
> AioContext. For anything spanning AioContexts you need
> bdrv_drain_all().
>
> Cc: Markus Armbruster <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/io.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgpG721LpMia4.pgp
Description: PGP signature