[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz. |
Date: |
Mon, 6 Jul 2015 14:43:32 -0700 |
On Mon, Jul 6, 2015 at 11:58 AM, Serge Vakulenko
<address@hidden> wrote:
> On Mon, Jul 6, 2015 at 12:33 AM, Antony Pavlov <address@hidden> wrote:
>> On Sun, 5 Jul 2015 21:18:11 -0700
>> Serge Vakulenko <address@hidden> wrote:
>>
>>> On Wed, Jul 1, 2015 at 6:41 AM, Aurelien Jarno <address@hidden> wrote:
>>> > On 2015-06-30 21:12, Serge Vakulenko wrote:
>>> >> Signed-off-by: Serge Vakulenko <address@hidden>
>>> >> ---
>>> >> hw/mips/Makefile.objs | 3 +
>>> >> hw/mips/mips_pic32mx7.c | 1652 +++++++++++++++++++++++++
>>> >> hw/mips/mips_pic32mz.c | 2840
>>> >> +++++++++++++++++++++++++++++++++++++++++++
>>> >> hw/mips/pic32_ethernet.c | 557 +++++++++
>>> >> hw/mips/pic32_gpio.c | 39 +
>>> >> hw/mips/pic32_load_hex.c | 238 ++++
>>> >> hw/mips/pic32_peripherals.h | 210 ++++
>>> >> hw/mips/pic32_sdcard.c | 428 +++++++
>>> >> hw/mips/pic32_spi.c | 121 ++
>>> >> hw/mips/pic32_uart.c | 228 ++++
>>> >> hw/mips/pic32mx.h | 1290 ++++++++++++++++++++
>>> >> hw/mips/pic32mz.h | 2093 +++++++++++++++++++++++++++++++
>>> >> 12 files changed, 9699 insertions(+)
>>> >> create mode 100644 hw/mips/mips_pic32mx7.c
>>> >> create mode 100644 hw/mips/mips_pic32mz.c
>>> >> create mode 100644 hw/mips/pic32_ethernet.c
>>> >> create mode 100644 hw/mips/pic32_gpio.c
>>> >> create mode 100644 hw/mips/pic32_load_hex.c
>>> >> create mode 100644 hw/mips/pic32_peripherals.h
>>> >> create mode 100644 hw/mips/pic32_sdcard.c
>>> >> create mode 100644 hw/mips/pic32_spi.c
>>> >> create mode 100644 hw/mips/pic32_uart.c
>>> >> create mode 100644 hw/mips/pic32mx.h
>>> >> create mode 100644 hw/mips/pic32mz.h
>>> >
>>> > This patch is huge, and needs to be splitted to ease the review.
>>>
>>> I'll prepare a new patch set, with every new file put into a separate
>>> message. Other issues fixed as well.
>>
>> Putting every new file into a separate message is a nonsense.
>> Please separate __logical changes__ into a single patch.
>
> Aurelien Jarno asked to split this patch to ease the review.
>
There are better ways to split the patch other than straight per-file
though. For example, header patches (e.g. for your structs) should go
with their accompanying C code changes.
git add -p is the interactive utility for selecting specific changes
to be included in a commit.
Regards,
Peter
>> --
>> Best regards,
>> Antony Pavlov
>
Message not available
- [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/01
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Aurelien Jarno, 2015/07/01
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/06
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/06
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/06
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz.,
Peter Crosthwaite <=
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/07
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Aurelien Jarno, 2015/07/07
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/02
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/06
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/06
Re: [Qemu-devel] [PATCH pic32 v2 0/5] Support for Microchip pic32mx7 and pic32mz microcontrollers, Antony Pavlov, 2015/07/02